Skip to content

Fixing CI scripts #90

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Fixing CI scripts #90

wants to merge 5 commits into from

Conversation

wks
Copy link
Collaborator

@wks wks commented Mar 31, 2025 •
edited
Loading

rustup --component should be comma-separated.

Removed the unmaintained action-rs/toolchain and assume the GitHub ubuntu image has the latest stable Rust toolchain installed.

Moved away from the ubuntu 20.04 which will be unsupported.

@wks
Copy link
Collaborator Author

wks commented Mar 31, 2025

If multiple components are specified, they should be separated by comma. The existing script is wrong, and the rustfmt in --component clippy rustfmt is interpreted as a toolchain, which does not exist. It somehow managed to work for a year, until it fails recently (see https://github.com/mmtk/mmtk-core/actions/runs/14162342634/job/39669733914?pr=1295).

@wks wks mentioned this pull request Mar 31, 2025
Merged
@wks wks changed the title rustup --component should be comma-separated Fixing CI scripts Mar 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@wks